Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changeset checker #5100

Merged
merged 5 commits into from
Jul 7, 2021
Merged

Fix changeset checker #5100

merged 5 commits into from
Jul 7, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jul 1, 2021 •
edited
Loading

There is a bug in the latest changesets: changesets/changesets#517

Instead of letting it implicitly try to use master, use --since option to specify base SHA, obtained from Github Actions' env variables. Keep master/HEAD as a fallback option in case this script is run locally.

@hsubox76 hsubox76 requested a review from egilmorez as a code owner July 1, 2021 21:47
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8b5552e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2021 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (61f0d7e) and head commit (47a0cec).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (61f0d7e) and head commit (47a0cec).

@hsubox76 hsubox76 changed the title TEST: See what's wrong with changeset checker Fix changeset checker Jul 1, 2021
@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Jul 2, 2021
@hsubox76 hsubox76 merged commit d10bd00 into master Jul 7, 2021
@hsubox76 hsubox76 deleted the ch-changeset-checker branch July 7, 2021 20:07
@firebase firebase locked and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @Feiyang1